Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from prettier to Biome #304

Merged
merged 17 commits into from
Feb 25, 2025
Merged

Switch from prettier to Biome #304

merged 17 commits into from
Feb 25, 2025

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Aug 23, 2024

Fixes #283

TODO:

biome vs prettier

Pros:

  • biome is much faster than prettier
  • prettier’s pre-commit repo is archived, biome’s is actively maintained

Cons:

Copy link

A PR has been generated to the instance repo:
scverse/cookiecutter-scverse-instance#142

You can check out the PR to preview your changes
in an instance of the cookiecutter template. The PR will be kept in sync with
this PR automatically.

@Zethson
Copy link
Member

Zethson commented Aug 23, 2024

Are they planning to format yaml?

@flying-sheep
Copy link
Member Author

yes

@g-plane

This comment was marked as off-topic.

@grst

This comment was marked as off-topic.

@flying-sheep flying-sheep marked this pull request as ready for review February 19, 2025 11:08
@grst
Copy link
Collaborator

grst commented Feb 24, 2025

some tests still failing though... not sure what happened

@flying-sheep
Copy link
Member Author

Should be fixed in Sphinx 8.2.1: sphinx-doc/sphinx#13366

@flying-sheep flying-sheep merged commit c0c3f02 into main Feb 25, 2025
7 checks passed
@flying-sheep flying-sheep deleted the biome branch February 25, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prettier alternatives
4 participants